Updated BufferTabs plugin so that tabs can be dragged and dropped.
Submitted | tygerpatch - 2012-07-16 03:13:33 | Assigned | |
---|---|---|---|
Priority | 5 | Labels | |
Status | open | Group | None |
Resolution | None |
2012-07-16 14:50:49 tygerpatch |
- **assigned_to**: nobody --> arobert |
---|---|
2012-07-18 15:41:23 ezust |
I'm trying it out now. I can drag, but I can't seem to drop. Is it supposed to allow
me to move a buffer from one EditPane to another? Or just reorder the tabs in a single
editpane? Because if I am sorting my buffers by name, then there is no point in drag
and drop unless it can go between editpanes and views.
|
2012-07-18 15:41:41 ezust |
- **assigned_to**: arobert --> nobody |
2012-07-18 15:50:22 kpouer |
In fact I don't understand. As far as I remember it was already possible to drag buffers
to reorder them (if the buffers are not sorted by jEdit) isn't it ?
|
2012-07-18 22:04:49 tygerpatch |
@kpouer The BufferTabs plugin shows through tabs all the files that you have opened.
But it doesn't allow you to visually rearrange them. This patch does that. GlassPane
is there in order to draw over the JTabbedPane to show the tab being dragged and to
indicate where the tab will be dropped to.
|
2012-07-19 03:40:18 ezust |
I tried the updated patch. I am still unable to drop into another split pane.
|
2012-07-19 10:37:21 tygerpatch |
Thanks for pointing out that drop doesn't work when buffersets are sorted. I will
try to fix this as soon as possible.
|
2012-07-19 13:27:45 ezust |
If your bufferset scope is not EditPane, then drag and drop between editpanes should
be forbidden.
|
2012-07-19 13:45:45 kpouer |
A very nice feature would be that if you drag outside a view from jEdit, it creates a new plain view with the buffer it it. |
2012-07-19 14:20:54 ezust |
Another nice feature would be: if the bufferset scope is not global, then dnd between
views should work too.
|
2012-07-21 01:17:31 tygerpatch |
Drag-n-Drop-BufferTabs.patch (17.2Kio) |
2012-07-21 01:20:05 tygerpatch |
Updated Patch.
|
2012-08-08 14:58:49 jarekczek |
Todd, you made many unnecessary changes which caused reindentation of large parts
of code. These changes are cosmetic. Cosmetic changes are here joined with significant
functionality changes. This makes it hard to understand the patch. Hard to analyze
it.
|
2012-08-08 16:10:22 ezust |
jarek, I don't understand the last 2 sentences of your previous comment.
|
2012-08-08 16:25:46 ezust |
Instead of creating a new view when dropped in an "undroppable region", it should
create a new view only when you drop OUTSIDE any existing view. Responding to drops
in an undroppable region is very confusing to the user and should not be done in BufferTabs.
|
2012-08-08 16:27:20 ezust |
- **status**: open --> pending-rejected |
2012-08-08 18:36:59 jarekczek |
Alan, the last 2 sentences. Todd submitted a patch having a given functionality in
mind. The patch is quite complex. And I see comments: you should also do ..., it would
be nice to have ... too. I think the patch should be first applied with the basic
functionality, once the problems are fixed.
|
2012-08-08 18:36:59 jarekczek |
- **assigned_to**: nobody --> ezust |
2012-08-08 20:59:57 tygerpatch |
- **status**: pending-rejected --> open-rejected |
2012-08-08 20:59:57 tygerpatch |
@jarekczek
|
2012-08-08 21:44:09 ezust |
> Todd submitted a patch having a given functionality in mind.
|
2012-08-09 06:28:55 jarekczek |
- **status**: open-rejected --> open |
2012-08-09 06:28:55 jarekczek |
I think the idea to see the destination of the tab being moved is worth introducing.
Although personally I don't like the big icon which obscures background. I vote for
accepting the original patch, if the reviewer accepts all the coding style.
|
2012-08-10 07:43:38 ezust |
- **assigned_to**: ezust --> jarekczek |
2012-08-10 07:43:38 ezust |
I just added a tabSize=4:indentSize=4:noTabs=false: to the top of each source file
in buffertabs in svn.
|
2012-08-15 19:38:23 jarekczek |
- **assigned_to**: jarekczek --> nobody |